Change in ovirt-engine[master]: userportal: SearchResultsLimit race condition (#853904)

[oourfali at redhat.com]

Oved Ourfali has submitted this change and it was merged.

Change subject: userportal: SearchResultsLimit race condition (#853904)
......................................................................


userportal: SearchResultsLimit race condition (#853904)

https://bugzilla.redhat.com/853904

SearchableListModel - a race condition in SearchResultsLimit
configuration value fetching prevented auto-refresh mechanism.

* SearchableListModel -> Search()
If 'SearchResultsLimit' isn't fetched yet,
'searchRequested' flag is marked on RequestSearch().

* RequestSearch()
Clear model's items and raise changed events
(affects only for first search).

* 'GetSearchResultsLimit' -> OnSuccess()
Search command should be invoked iff 'searchRequested' and
model's timer isn't running (since Search starts the timer).
Checking 'getIsTimerDisabled' is not sufficient since the timer
is being started only *after* SearchResultsLimit value is fetched.

* MainTabBasicDetailsView
Add clear() method for cleaning details pane.

Change-Id: I6dfe218a57694f61fcd3445894c06f8918fe3739
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
3 files changed, 37 insertions(+), 4 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6dfe218a57694f61fcd3445894c06f8918fe3739
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>