Change in ovirt-engine[master]: webadmin: SanStorageTargetToLunList FindBugs

derez at redhat.com derez at redhat.com
Tue Sep 25 05:36:48 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: SanStorageTargetToLunList  FindBugs
......................................................................


webadmin: SanStorageTargetToLunList  FindBugs

Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE.

The items variable is clearly not null here, since isEmpty() is
called on it beforehand, so the conditional statement can be safely
removed.

Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>



More information about the Engine-commits mailing list