Change in ovirt-engine[master]: userportal, webadmin: ClusterModel FindBugs

derez at redhat.com derez at redhat.com
Thu Sep 27 11:41:35 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: userportal,webadmin: ClusterModel FindBugs
......................................................................


userportal,webadmin: ClusterModel FindBugs

In StoragePool_SelectedItemChanged, selectedDataCenter is validated to
be non-null in the beginning of the method, so further checks are
redundant, and can be safely removed.

Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>



More information about the Engine-commits mailing list