Change in ovirt-engine[master]: core: Fix for wrong error massage in add disk

gchaplik at redhat.com gchaplik at redhat.com
Tue Apr 2 07:28:08 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: Fix for wrong error massage in add disk
......................................................................


core: Fix for wrong error massage in add disk

while quota in audit mode, when user tried to add a disk to an SD which
has no assigned quota - an error message was presented and the operation
was blocked. The error message was not correctly formatted.

This happens because when the DC was moved from Enforced to Audit mode
the quota cache was not refreshed. So all quotas on that DC remained in
the old enforcement mode.

Fixed the cache refresh rule. Now that the error is thrown from the
correct place in the code and only in Enforced mode, it is correctly
formatted.

Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2
Bug-Url: https://bugzilla.redhat.com/906485
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
2 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13195
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: noam slomianko <nslomian at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list