Change in ovirt-engine[master]: core: Remove unused GetVmsByVmTemplateGuidQuery

amureini at redhat.com amureini at redhat.com
Thu Apr 4 10:24:02 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
......................................................................


core: Remove unused GetVmsByVmTemplateGuidQuery

GetVmsByVmTemplateGuidQuery is not used anywhere in the code, and
hence should be removed.

This patch removes the following:
1. The unused GetVmsByVmTemplateGuidQuery class.
2. The GetVmsByVmTemplateGuidParameters class used by the
   aforementioned query class. All its meaningful methods (i.e., getId()
   and the constructor from Guid were pulled up to
   GetVmTemplatesDisksParameters which used to extend it.
3. The GetVmsByVmTemplateGuid constant in VdcQueryType
   corresponding to the removed class.

Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByVmTemplateGuidQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesDisksParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByVmTemplateGuidParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
4 files changed, 9 insertions(+), 42 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list