Change in ovirt-engine[master]: core: Remove HasFreeVmsInPool

[lhornyak at redhat.com]

Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Remove HasFreeVmsInPool
......................................................................


core: Remove HasFreeVmsInPool

HasFreeVmsInPoolQuery is not used anywhere in
the code, and hence should be removed.

This patch removes the following:
1. The HasFreeVmsInPoolQuery class
2. The HasFreeVmsInPool constant representing
   it in VdcQueryType
3. The HasFreeVmsInPoolParameters class which
   was only used by the removed query class.
4. Moved several static methods from VmPoolCommandBase which were used
   by HasFreeVmsInPoolQuery and AttachUserToVmFromPoolAndRunCommand to
   AttachUserToVmFromPoolAndRunCommand, as it is now the only command
   that uses them - getVmToAttach(NGuid),
   getPrestartedVmToAttach(NGuid), getNonPrestartedVmToAttach(NGuid).
   These methods' visibility was also reduced to private, as they no
   longer need to be used outside this class.

Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasFreeVmsInPoolQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasFreeVmsInPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
5 files changed, 37 insertions(+), 67 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>