Change in ovirt-engine[master]: core: findbugs + improving code

yzaslavs at redhat.com yzaslavs at redhat.com
Fri Apr 19 01:34:25 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: findbugs + improving code
......................................................................


core: findbugs + improving code

Fixing findbugs issue + improving code
readability

1. Removed dictemp + assigntmet
2. Changed the if instanceof map "pattern"

Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 5 insertions(+), 11 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list