Change in ovirt-engine[master]: frontend: fluent API instead of temporary fields

[alkaplan at redhat.com]

Alona Kaplan has submitted this change and it was merged.

Change subject: frontend: fluent API instead of temporary fields
......................................................................


frontend: fluent API instead of temporary fields

This patch replace the usage of temporary fields with fluent API - where
setters return a reference to "this" which can be used to make
further calls on the return value of the setter method.

Not all setters were changed in this patch of course, only those that
were relevant to simplify the code which is related to run-once
capability (this patch is part of few patches that were done lately to
refactor the areas around run-once capability in the frontend)

This patch also includes:
1. remove the auto-assign entity setting which is not needed because it
is already done in WebadminRunOnceModel#init method
2. move the duplicate code of display protocol settings in run-once
mode from UserPortalListModel and VmListModel to be just in RunOnceModel

Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
10 files changed, 65 insertions(+), 108 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13246
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>