Change in ovirt-engine[master]: engine: TimeoutBase - Improving memory footprint - continue

mkublin at redhat.com mkublin at redhat.com
Wed Apr 24 08:52:41 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: TimeoutBase - Improving memory footprint - continue
......................................................................


engine: TimeoutBase - Improving memory footprint - continue

After changes inside TimeoutBase, I found out that the cache is used only as place holder,
so instead of putting TimeouBase object to cache I decided to put String, also possible to put
some king const Object but, I think it is not make any difference
Benefit - String should take less memory than TimeoutBase will all loaded objects from DB

Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java
2 files changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14158
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika at gmail.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list