Change in ovirt-engine[master]: core: [cleanup] split execute method of CreateAllSnapshots

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Apr 25 13:13:18 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: [cleanup] split execute method of CreateAllSnapshots
......................................................................


core: [cleanup] split execute method of CreateAllSnapshots

CreateAllSnapshotsFromVmCommand#executeVmCommand method is too long.
it's going to be even longer after adding memory snapshot, so it's a
good point to organize it by spliting the different concerns in this
method to several private methods.

Change-Id: Ie401b3aa60abba497237e02c77d8d3a77cef9a20
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
2 files changed, 33 insertions(+), 23 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie401b3aa60abba497237e02c77d8d3a77cef9a20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list