Change in ovirt-engine[master]: core: Enhance for loop at import VM.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Aug 6 12:02:49 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Enhance for loop at import VM.
......................................................................


core: Enhance for loop at import VM.

The for loop in the import VM commands iterates over the volumes of
the image, besides the last one.
this behaviour is not logic and error prone, all volumes of the image
should be set with the same disk id

Change-Id: I6f6ca389739143f5102e0ef940fe6fac0164b17d
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17172
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f6ca389739143f5102e0ef940fe6fac0164b17d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list