Change in ovirt-engine[master]: core: Add storage validation when plugging an image.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Aug 6 12:02:50 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Add storage validation when plugging an image.
......................................................................


core: Add storage validation when plugging an image.

When a plugging a disk to a VM, the engine should validate that the storage
domain that the disk resides on is active.
There is no reason to call VDSM if it can't connect to the storage.

The validation should be done on plug disk, and also on its derived
operation attachDisk.

Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263
Bug-Url: https://bugzilla.redhat.com/969767
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java
4 files changed, 73 insertions(+), 11 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list