Change in ovirt-engine[master]: core: remove unnecessary allocation of Guid

amureini at redhat.com amureini at redhat.com
Tue Aug 6 18:43:32 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: remove unnecessary allocation of Guid
......................................................................


core: remove unnecessary allocation of Guid

Remove unnecessary allocation and cloning of Guid
when assigning id values to objects.
Removed cloning in 2 places, in third place its usage
was in unused method, so removed the method.

Change-Id: I857b4fe7ad1f1dcff486e489e262441823a6cb3e
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
3 files changed, 5 insertions(+), 12 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I857b4fe7ad1f1dcff486e489e262441823a6cb3e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list