Change in ovirt-engine[master]: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao

masayag at redhat.com masayag at redhat.com
Thu Aug 8 18:34:34 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao
......................................................................


engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao

The patch performs the following:
1. Standardize VmNetworkInterfaceDao by proper inheritance
2. Utilize VmNicRowMapperBase for VmNetworkInterfaceDao mapper
3. Standardize stored-procedure names and organize vm network
   interface views.
4. Some cleanup.
5. Remove methods which can be invoked from VmNicDao
6. Fix stored procedure to consider vnic_profiles as the
   mediator between vm nic and network.

Change-Id: Iea17ab1f7b686c5674b33b353794456450719f8f
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoTest.java
M packaging/dbscripts/network_sp.sql
7 files changed, 130 insertions(+), 212 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea17ab1f7b686c5674b33b353794456450719f8f
Gerrit-PatchSet: 34
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list