Change in ovirt-engine[master]: core: simplify iso path validation on run vm

amureini at redhat.com amureini at redhat.com
Sun Aug 18 13:40:28 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: simplify iso path validation on run vm
......................................................................


core: simplify iso path validation on run vm

Simplified the iso path validation code that is being executed on run VM
by extracting the code that iterate over the images in the iso domain
looking for the floppy/disk path to separate method, and reduce the
number of nested levels and redundant fields in it.

Change-Id: I7c1734497fdb22093ec507243ef1ae6bc5006220
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 27 insertions(+), 48 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c1734497fdb22093ec507243ef1ae6bc5006220
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list