Change in ovirt-engine[master]: core: Remove member init in the query parameters

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove member init in the query parameters
......................................................................


core: Remove member init in the query parameters

Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.

To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.

As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).

This patch takes care of the query parameter classes.

Change-Id: Ic89595cd4e26b7fca901d62ba57f4cfdf29c12b1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllFromExportDomainQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDeviceListQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetExistingStorageDomainListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermissionsForObjectParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainAndPoolQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookContentQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java
17 files changed, 42 insertions(+), 29 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18135
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic89595cd4e26b7fca901d62ba57f4cfdf29c12b1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server