Change in ovirt-engine[master]: core: Remove StorageDomainStatic ctor used in test

amureini at redhat.com amureini at redhat.com
Tue Aug 20 06:46:53 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove StorageDomainStatic ctor used in test
......................................................................


core: Remove StorageDomainStatic ctor used in test

Removed the ctor that isn't used anywhere in production code.
This in fact also makes the tests easier to understand, as now the
test StorageDomainStatics instances only have the relevant field
values and not all the values demanded by this useless constructor.

Change-Id: I9d41209108011b2daacfb77d4ae4f2af09086938
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
2 files changed, 12 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18117
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d41209108011b2daacfb77d4ae4f2af09086938
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list