Change in ovirt-engine[master]: core: Adding getRpmRevision to RpmVersion

yzaslavs at redhat.com yzaslavs at redhat.com
Tue Aug 20 14:35:17 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Adding getRpmRevision to RpmVersion
......................................................................


core: Adding getRpmRevision to RpmVersion

RpmVersion should be improved and rewritten in such
a way that frontend and engine will not need to use two classes.
However, for now an interim version is presented - calculation of the
RpmRevision part - RpmRevision part can be in format of a colon
delimited string, and has nothing to do with the revision field of
Version (in the future we will also change the inheritance)

Change-Id: I52499df93cd7cadc6efb6c49484ea95b1c95fb59
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RpmVersion.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RpmVersionTest.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RpmVersion.java
3 files changed, 57 insertions(+), 10 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52499df93cd7cadc6efb6c49484ea95b1c95fb59
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list