Change in ovirt-engine[master]: engine : Null Pointer Exception for action CreateAllSnapshot...

amureini at redhat.com amureini at redhat.com
Thu Aug 29 06:35:35 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................


engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot

After a failure in create snapshot, engine enters into
a loop with NullPointerException. This patch fixes the
case where the vdsm was restarted after submission of the
command and the entry in snapshots table was cleared by engine
leading to NPE in CreateAllSnapshotsFromVmCommand.

Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Bug-Url: https://bugzilla.redhat.com/982003
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list