Change in ovirt-engine[master]: core: cleanup in MoveOrCopyDiskCommand

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: cleanup in MoveOrCopyDiskCommand
......................................................................


core: cleanup in MoveOrCopyDiskCommand

- simplify canDoAction checks by calling CommandBase#failCanDoAction
- replace if-else statement with ternary if
- rename fields that are used for caching to being with 'cache' prefix
- remove the canDoActionMessages parameter from checkImageConfiguration
  method, the messages list is fetched inside the method instead

Change-Id: Id28853bca622bf19ef66c983fa2d7ea38b943fa7
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
2 files changed, 35 insertions(+), 50 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id28853bca622bf19ef66c983fa2d7ea38b943fa7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server