Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix feedback image visiblity issue

iheim at redhat.com iheim at redhat.com
Mon Dec 2 15:09:44 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: fix feedback image visiblity issue
......................................................................


webadmin: fix feedback image visiblity issue

'Feedback' section in the right-top will be hidden
if there is no feedback-url is available.
But that section is a collection images and text,
not all of them were hidden when no feedback-url supplied.

This is fixed by making the whole feedback panel
invisible if there is no feedback-url available.

Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=968511
Signed-off-by: Kanagaraj M <kmayilsa at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
3 files changed, 17 insertions(+), 8 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list