Change in ovirt-engine[master]: webadmin, userportal: Support generic TextBoxLabel widget

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Support generic TextBoxLabel widget
......................................................................


webadmin,userportal: Support generic TextBoxLabel widget

1. Created TextBoxLabelBase (abstract class) with generic
   type parameter and common behavior taken from original
   TextBoxLabel widget

2. Modified TextBoxLabel to extend TextBoxLabelBase<String>
   with String-specific behavior taken from original
   TextBoxLabel widget

This patch is meant to support creating custom (type-specific)
TextBoxLabel widgets to replace any ValueLabel widgets within
"General" sub tab views to achieve consistent look & feel.

For example, this patch should support replacing this:

  public class VersionLabel
      extends ValueLabel<RpmVersion> {

    public VersionLabel() {
      super(new VersionRenderer());
    }

  }

with this:

  public class VersionTextBoxLabel
      extends TextBoxLabelBase<RpmVersion> {

    public VersionTextBoxLabel() {
      super(new VersionRenderer());
    }

  }

Change-Id: I728f7d6fdc74523ac397225c1c5833cb84f6eef9
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java
2 files changed, 113 insertions(+), 56 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I728f7d6fdc74523ac397225c1c5833cb84f6eef9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server