Change in ovirt-engine[master]: core: [Fix] Check PCI limits when adding NICs

masayag at redhat.com masayag at redhat.com
Tue Dec 10 12:03:06 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: core: [Fix] Check PCI limits when adding NICs
......................................................................


core: [Fix] Check PCI limits when adding NICs

The AddVmInterfaceCommand didn't account for all the existing NICs
while passing the "interfaces" list to the checkPciAndIdeLimits
procedure, so a limitless number of NICs could be created.
This change fix this behaviour (like in the UpdateVmInterfaceCommand).

Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa at eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list