Change in ovirt-engine[master]: engine: Simplify AddExistingFileStorageDomainCommand

amureini at redhat.com amureini at redhat.com
Wed Dec 11 16:38:37 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Simplify AddExistingFileStorageDomainCommand
......................................................................


engine: Simplify AddExistingFileStorageDomainCommand

1. Use regular imports instead of inline.
2. Use quick return in case of failure.
3. Use shorter runVdsCommand.

Change-Id: I21960f64d45c01a65978a44d5874b8c94dfb9420
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
1 file changed, 26 insertions(+), 34 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21323
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21960f64d45c01a65978a44d5874b8c94dfb9420
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list