Change in ovirt-engine[master]: webadmin: Refactoring in ProfilesInstanceTypeEditor

[lvernia at redhat.com]

Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Refactoring in ProfilesInstanceTypeEditor
......................................................................


webadmin: Refactoring in ProfilesInstanceTypeEditor

Replaced the non-standard edit() method with the standard one, that
had been previously marked as deprecated. This required introducing a
new class VnicInstancesModel, but it's better practice (now developers
don't have to be trusted to use the "correct" edit() method). Also
took the chance to parameterize all the related ListModel instances,
as the class is now generic.

Change-Id: I5951932037850a56f861bfced9199640153db785
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VnicInstancesModel.java
5 files changed, 24 insertions(+), 52 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5951932037850a56f861bfced9199640153db785
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server