Change in ovirt-engine[master]: core: fix NPE on failure to run stateless vm

rgolan at redhat.com rgolan at redhat.com
Sun Dec 15 14:14:12 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: core: fix NPE on failure to run stateless vm
......................................................................


core: fix NPE on failure to run stateless vm

Running VM in stateless mode is composed of two parts: the stateless
snapshot creation and then running the VM. In the second part we invoke
RunVmCommand and ask it to end the operation's job when it is done.

The problem was that RunVmCommand didn't get the operation's job, so
when it tried to end the job, NPE was thrown and the job's tasks
remained unfinished. This problem is solved by passing the operation's
job to the inner RunVmCommand.

Change-Id: I922b0cfaf9a50de35ec9c2ca6195d5326600ce5a
Bug-Url: https://bugzilla.redhat.com/1039507
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Roy Golan: Looks good to me, approved
  Moti Asayag: Looks good to me, but someone else must approve
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/22390
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I922b0cfaf9a50de35ec9c2ca6195d5326600ce5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list