Change in ovirt-engine[master]: engine: fix locking issue in GlusterMultipleActionsRunner

[sanjal at redhat.com]

Shireesh Anjal has submitted this change and it was merged.

Change subject: engine: fix locking issue in GlusterMultipleActionsRunner
......................................................................


engine: fix locking issue in GlusterMultipleActionsRunner

GlusterMultipleActionsRunner#executeValidatedCommands() had code to
re-acquire the lock released at the end of canDoAction. However, this
should not happen in case the CanDoAction had failed, as
MultipleActionsRunner#executeValidatedCommand() doesn't even execute
the command in this case.

Performed a minor refactoring in MultipleActionsRunner as follows:
- renamed executeValidatedCommands() to executeValidatedCommand()
- executeValidatedCommand() gets called only when canDoAction was success

Change-Id: I100603d7155deb67bb2f0a8b451732a0003fbf55
Bug-Url: https://bugzilla.redhat.com/905904
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GlusterMultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
3 files changed, 21 insertions(+), 20 deletions(-)

Approvals:
  Shireesh Anjal: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I100603d7155deb67bb2f0a8b451732a0003fbf55
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>