Change in ovirt-engine[master]: core: Streamline TryBackToAllSnapshots canDoAction

amureini at redhat.com amureini at redhat.com
Sun Feb 3 09:34:36 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Streamline TryBackToAllSnapshots canDoAction
......................................................................


core: Streamline TryBackToAllSnapshots canDoAction

Refactored TryBackToAllSnapshotsOfVmCommand.canDoAction to be more
readable using the early return pattern and overriding
setActionMessageParameters().

Change-Id: I0c96b782837e3a4eaef5399ca20a2b0738db3370
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
1 file changed, 24 insertions(+), 20 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c96b782837e3a4eaef5399ca20a2b0738db3370
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list