Change in ovirt-engine[master]: core: Remove domains member from storage_pool

amureini at redhat.com amureini at redhat.com
Sun Feb 3 20:33:13 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove domains member from storage_pool
......................................................................


core: Remove domains member from storage_pool

Removed the private member "domains" from the storage_pool class. This
member was never updated (in fact, there are no methods to modify it!),
and never queried (no such methods exists either), and was only used in
the equals(Object) and hashCode() methods. Since its value is always
null, it's useless to continue holding it.

Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java
1 file changed, 1 insertion(+), 11 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11642
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list