Change in ovirt-engine[master]: webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOpt...

asaf at redhat.com asaf at redhat.com
Wed Feb 6 15:17:59 UTC 2013


Asaf Shakarchi has submitted this change and it was merged.

Change subject: webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork
......................................................................


webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork

There's a possible branch of statement, that if executed
a null value will be dereferenced. this patch verifies that the var
is not null before using it.

Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7
Signed-off-by: Asaf Shakarchi <asaf at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Asaf Shakarchi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list