Change in ovirt-engine[master]: webadmin: A NPE check in SetupNetworksModel:onEdit

asaf at redhat.com asaf at redhat.com
Wed Feb 6 15:19:30 UTC 2013


Asaf Shakarchi has submitted this change and it was merged.

Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit
......................................................................


webadmin: A NPE check in SetupNetworksModel:onEdit

There's a possible branch of statement, that if executed
a null value will be dereferenced. this patch verifies that the model
editPopup is not null before dereferenced.

Change-Id: I165a3f298bc306d65cefceef3a8dfd24dc366774
Signed-off-by: Asaf Shakarchi <asaf at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Asaf Shakarchi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I165a3f298bc306d65cefceef3a8dfd24dc366774
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list