Change in ovirt-engine[master]: core: Remove user_sessions table

amureini at redhat.com amureini at redhat.com
Sun Feb 10 17:17:43 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove user_sessions table
......................................................................


core: Remove user_sessions table

The user_sessions table is part of the old login/logout mechanism,
which is no longer in use.

Before this patch, the table still existed, as well as code that
queries it and deletes from it, but no occurrences of inserting or
updating it, which means it was effectively useless.

This patch drops it from the database, and removes any remnants of code
that still reference it, including the session_count column of the
users table (and the corresponding members of the DbUser class).

Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
A backend/manager/dbscripts/upgrade/03_02_0420_remove_user_session.sql
M backend/manager/dbscripts/user_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions.java
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions_id.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
12 files changed, 18 insertions(+), 647 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list