Change in samples-uiplugins[master]: Shell-In-A-Box plugin: refactoring and renaming

derez at redhat.com derez at redhat.com
Tue Feb 12 12:51:02 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: Shell-In-A-Box plugin: refactoring and renaming
......................................................................


Shell-In-A-Box plugin: refactoring and renaming

* Using 'hostname' property instead of 'name'.
* Refactoring 'getShellInABoxUrl' method signature
  to get the selected host.
* Renaming all occurrences of 'Shell Box' to 'Shell In A Box'.
* Removing 'isAccessible' method.

Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8
Signed-off-by: Daniel Erez <derez at redhat.com>
---
D shellbox-plugin/shellbox-files/start.html
D shellbox-plugin/shellbox.json
R shellinabox-plugin/README
A shellinabox-plugin/shellinabox-files/start.html
A shellinabox-plugin/shellinabox.json
5 files changed, 53 insertions(+), 57 deletions(-)

Approvals:
  Daniel Erez: Verified
  Vojtech Szocs: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8
Gerrit-PatchSet: 1
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list