Change in ovirt-engine[master]: webadmin, userportal: gwt-maven-plugin POM cleanup

asaf at redhat.com asaf at redhat.com
Fri Feb 15 22:53:23 UTC 2013


Asaf Shakarchi has submitted this change and it was merged.

Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup
......................................................................


webadmin,userportal: gwt-maven-plugin POM cleanup

This patch eliminates some duplicities in WebAdmin and UserPortal
POM files and adds new feature with regard to 'gwtdev' profile.

1. Common properties used with GWT compilation moved to parent
   POM's <properties>

2. Common gwt-maven-plugin plugin configuration moved to parent
   POM's <pluginManagement>

3. 'all-langs' profile definition moved to parent POM's <profiles>

4. Activating 'gwtdev' profile when compiling GWT application
   (not debugging) will produce 'DETAILED' JavaScript output
   and enable draft compile (should be faster)

Item 4. makes it a bit easy to analyze/profile GWT application
during development.

Change-Id: I1d064980ac3269373b1c17040bcc1b5cd704445f
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
3 files changed, 81 insertions(+), 133 deletions(-)

Approvals:
  Asaf Shakarchi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12071
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d064980ac3269373b1c17040bcc1b5cd704445f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list