Change in ovirt-engine[master]: core: Cleanup VmPoolCommandBase#isVmFree

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Cleanup VmPoolCommandBase#isVmFree
......................................................................


core: Cleanup VmPoolCommandBase#isVmFree

Cleaned up VmPoolCommandBase's isVmFree method to make it more readable:
1. Adopted an early-return paradigm
2. Removed redundant null checks on messages. This method is only called
   from canAttachNonPrestartedVmToUser, which always passes a new
   ArrayList instance.

Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
1 file changed, 59 insertions(+), 68 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>