Change in ovirt-engine[master]: core: auto generate Handler fields from annotations

rgolan at redhat.com rgolan at redhat.com
Sun Feb 17 15:15:43 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: core: auto generate Handler fields from annotations
......................................................................


core: auto generate Handler fields from annotations

Use annotated fields to generate what fields can be edited and
on which status.

Introduced 2 annotations;

 @EditableField
 private String name;

 @EditableOnVmStatus(status = Down)
 private Guid vdsGroupId;

note: several field names have bean updated to comply to java property
convention.

Signed-off-by: Roy Golan <rgolan at redhat.com>
Change-Id: I8441f030c161c99c630a945b8b0228114665aa17
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableField.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVdsStatus.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVmStatusField.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
11 files changed, 229 insertions(+), 113 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8441f030c161c99c630a945b8b0228114665aa17
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list