Change in ovirt-engine[master]: core: Fix UpdateVm permissions check for Quota

[gchaplik at redhat.com]

Gilad Chaplik has submitted this change and it was merged.

Change subject: core: Fix UpdateVm permissions check for Quota
......................................................................


core: Fix UpdateVm permissions check for Quota

Quota permissions were checked regardless of the vm state
(running/stopped), the quota enforcement mode (Audit/enforcing) and the
change in quota selection box.

addQuotaPermissionSubject was change to check for quota consumption permissions only
if the quota was changed & quota is Enforced & vm is running.
Otherwise, User could edit vm without having quota consumption
permissions.

Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Bug-Url: https://bugzilla.redhat.com/904105
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
2 files changed, 14 insertions(+), 3 deletions(-)

Approvals:
  ofri masad: Verified
  Gilad Chaplik: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>