Change in ovirt-engine[master]: engine: Refactored code into NetworkValidator class

[mkolesni at redhat.com]

Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Refactored code into NetworkValidator class
......................................................................


engine: Refactored code into NetworkValidator class

The NetworkValidator class handles network validation on the data center
level, and is instantiated on a per-network basis. This validation had
previously been performed by the NetworkCommon class and its derived
classes, but now the NetworkValidator may be used as a service provider.

A corresponding test class is added.

While refactoring fixed inconsistency bug related to add/update network
commands.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905479

Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java
7 files changed, 582 insertions(+), 201 deletions(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Lior Vernia: Verified


--
To view, visit http://gerrit.ovirt.org/10940
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>