Change in ovirt-engine[master]: packaging: changed psql parser in engine-upgrade.getCompensa...

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Feb 21 14:06:09 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: packaging: changed psql parser in engine-upgrade.getCompensations
......................................................................


packaging: changed psql parser in engine-upgrade.getCompensations

In engine-upgrade getCompensations previously parsed the output
of psql searching for "0 rows" as flag for "no records found" and
failed on locale like Italian where it is "0 righe".
It also avoid to do the wrong thing if it contains a string like
"10 rows".
Now the parser doesn't rely on a localized string for detecting an
empty set.

Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a
Bug-Url: https://bugzilla.redhat.com/912426
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12220
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list