Change in ovirt-engine[master]: core: simplify VDSGroup.equals()

dfediuck at redhat.com dfediuck at redhat.com
Thu Feb 21 17:12:05 UTC 2013


Doron Fediuck has submitted this change and it was merged.

Change subject: core: simplify VDSGroup.equals()
......................................................................


core: simplify VDSGroup.equals()

Instead of manually doing a null-safe comparison for each VDSGroup
object, use ObjectUtils.objectsEqual().  Also, optimize the order of
comparison by looking at the id field first.

Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
1 file changed, 20 insertions(+), 94 deletions(-)

Approvals:
  Doron Fediuck: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>



More information about the Engine-commits mailing list