Change in ovirt-engine[master]: build: NlsCheck - proper inner class

amureini at redhat.com amureini at redhat.com
Fri Feb 22 15:10:58 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: build: NlsCheck - proper inner class
......................................................................


build: NlsCheck - proper inner class

Made the inner class QuotedString private static, as it is not used
outside this class and does not require access to the enclosing class'
members.

Also removed the redundant semicolon at the end of the declaration.

Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12251
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list