Change in ovirt-engine[master]: core: Remove vdsGroups member from storage_pool

amureini at redhat.com amureini at redhat.com
Sun Feb 24 06:40:46 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove vdsGroups member from storage_pool
......................................................................


core: Remove vdsGroups member from storage_pool

Removed the private member "vdsGroups" from the storage_pool class.
This member was never updated (in fact, there are no methods to
modify it!), and never queried (no such methods exists either), and
was only used in the equals(Object) and hashCode() methods.
Since its value is always null, it's useless to continue holding it.

Change-Id: I5ffad5811b390fd25562e677c7d852fb24ac4284
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java
1 file changed, 1 insertion(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/12327
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ffad5811b390fd25562e677c7d852fb24ac4284
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list