Change in ovirt-engine[master]: core: Move lock RunVmCommand -> RunVmCommandBase

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Move lock RunVmCommand -> RunVmCommandBase
......................................................................


core: Move lock RunVmCommand -> RunVmCommandBase

Move RunVmCommand's exclusive lock up to its ancestor, RunVmCommandBase.

RunVmCommand and all it's extending classes' locking will remain
unchanged (as they inherit the lock from RunVmCommandBase), and the
migration flows will also benefit from the lock.
This is done in order to solve a race in virt/storage migration flows,
like the bug mentioned below, and makes sense regardless - you can't
start running a VM, e.g., if it's in the middle of migrating to another
host.

Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0
Bug-Url: https://bugzilla.redhat.com/878131
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
2 files changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12315
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>