Change in ovirt-engine[master]: core: prevent db updates due to change in lastStartTime

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Jan 6 12:14:22 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: prevent db updates due to change in lastStartTime
......................................................................


core: prevent db updates due to change in lastStartTime

This patch prevents unneccesary updates of VMs by VdsUpdateRunTimeInfo
monitoring in case the 'lastStartTime' attribute is the only attribute
of the VM that is changed (received with a different value from vdsm).

The 'lastStartTime' attribute is always received from vdsm with null
value, which is different from its value in the engine, thus
VdsUpdateRunTimeInfo thinks that the VM is changed and update it in
the DB (and that happens in every monitoring iteration).

The solution is to remove 'lastStartTime' attribute from the list
of attributes which are, when received from vdsm, compared to their
values in the engine in order to decide whether the VM is changed.

Change-Id: I8193defc1833e33bb3f8809d8416012c6dc27aea
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified


--
To view, visit http://gerrit.ovirt.org/10616
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8193defc1833e33bb3f8809d8416012c6dc27aea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list