Change in ovirt-engine[master]: core: fix logging and mispelling in few classes

amureini at redhat.com amureini at redhat.com
Mon Jan 14 13:44:40 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: fix logging and mispelling in few classes
......................................................................


core: fix logging and mispelling in few classes

1.Fix mispelling of comment
2.Rephrase logging message
3.Log exception in error instead of debug
4.Getting the correct logger of same class in PasswordValueHelper
5.Not log same exception twice as error and debug, instead have one
unified logging in error for both message and corresponding exception

Change-Id: I1da28578bec13daa58e19081d78f6dbb07f264ca
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
7 files changed, 12 insertions(+), 18 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10951
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1da28578bec13daa58e19081d78f6dbb07f264ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list