Change in ovirt-engine[master]: core: Remove VMStatus#isGuestUp method

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Jan 15 08:01:18 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: Remove VMStatus#isGuestUp method
......................................................................


core: Remove VMStatus#isGuestUp method

The method VMStatus#isGuestUp is removed.

The method was called from one place in VdsUpdateRunTimeInfo to
check whether the status of a VM that was in MigrationFrom status
changed to Up/PoweringDown/PoweredDown/PoweringUp in the source host,
which means that the migration failed and needs to be re-run.

The above call was replaced with a check that the VM is not in
MigrationFrom status and a call to VMStatus#isRunning - in those cases
(which include WaitForLaunch + RebootInProgress in addition to the
statuses mentioned above) we want the migration process to re-run.

Change-Id: Iab3535e3bd6abaf61b244ac456bb93eb0218174e
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
2 files changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified


--
To view, visit http://gerrit.ovirt.org/10978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab3535e3bd6abaf61b244ac456bb93eb0218174e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list