Change in ovirt-engine[master]: core: Early return RemoveDiskCommand.canDoAction()

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Early return RemoveDiskCommand.canDoAction()
......................................................................


core: Early return RemoveDiskCommand.canDoAction()

Converted RemoveDiskCommand.canDoAction() to use the early return
pattern for increased readability.

This patch includes the described code changes and a small unit test
proving canDoAction()'s flow was not damaged.

Change-Id: I32eb51e9e3cee5920f90b8f1ff8a8148a10cf2f1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
2 files changed, 92 insertions(+), 12 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11012
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32eb51e9e3cee5920f90b8f1ff8a8148a10cf2f1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>