Change in ovirt-engine[master]: core: SnapshotValidatorTest ID generation

amureini at redhat.com amureini at redhat.com
Sun Jan 20 13:20:42 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: SnapshotValidatorTest ID generation
......................................................................


core: SnapshotValidatorTest ID generation

Changed the vmId  and snapshotId used for the test to be data members and
initialized them in the @Before method, as per JUnit best practices.

Change-Id: Ibfbc8e41b3505a104bb8b339fec9d7f9f7865b0c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java
1 file changed, 4 insertions(+), 14 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11178
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfbc8e41b3505a104bb8b339fec9d7f9f7865b0c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list