Change in ovirt-engine[master]: gluster: Do not log removal of option group

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Jan 24 09:49:50 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: gluster: Do not log removal of option group
......................................................................


gluster: Do not log removal of option group

The option "group" is a special case, where glusterfs internally
replaces it with the options defined in corresponding group file.
Hence, every time you set the option group, it eventually gets
replaced with a set of options.

For this reason, it is not appropriate to create an audit log when
GlusterManager detects that the option "group" has been removed.
Hence added a check to avoid the same.

Change-Id: Ic1fc981563239ca2209c7172805d802a9691cce4
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
2 files changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1fc981563239ca2209c7172805d802a9691cce4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>



More information about the Engine-commits mailing list