Change in ovirt-engine[master]: core: add the image block alignment scan

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: add the image block alignment scan
......................................................................


core: add the image block alignment scan

This patch introduces the new command required to scan the block
alignment of disks (both images and direct LUNs).
The new XML-RPC call issued to VDSM is:

 scanDiskAlignment(vmId, driveSpecs)

vmId is the UUID of the VM that is attached to the disk or a blank
UUID in case of a floating disk (not included in this patch yet).
In the future the vmId can be used to identify a running VM and
execute the scan through a guest agent in those cases where it's
impossible to do it concurrently (e.g. COW disk format).
The driveSpecs parameter is in the same format used when starting
a VM on a VDSM host:

 driveSpecs = {
   'poolID':   <poolID>,
   'domainID': <domainID>,
   'imageID':  <imageID>,
   'volumeID': <volumeID>,
 }

Or for direct LUNs:

 driveSpecs = {
   'GUID': <GUID>,
 }

The expected information returned in case of success is:

 alignmentInfo = {
   'status': {'message': 'Done', 'code': 0},
   'alignment': {
      '/dev/sda1': True,
      '/dev/sda2': True,
 }}

The result (with the scan execution timestamp) is stored in the
base_disks table (as other similar properties such as the bootable
and shareable flags).

The feature page can be found at:

 http://www.ovirt.org/Features/DiskAlignment

Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskAlignment.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AlignmentScanReturnForXmlRpc.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDiskAlignmentVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/base_disks_sp.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0320_base_disks_alignment.sql
27 files changed, 747 insertions(+), 9 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server